Skip to content

http: fix rawHeaders exceeding maxHeadersCount limit #61285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Jan 22, 2026
Merged

http: fix rawHeaders exceeding maxHeadersCount limit #61285

nodejs-github-bot merged 1 commit into from
Jan 22, 2026
+30 −2

Conversation

@Meltedd
Copy link
Contributor

@Meltedd Meltedd commented Jan 5, 2026

Fixes: #61284

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 5, 2026

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Jan 5, 2026
@codecov
Copy link

codecov bot commented Jan 5, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (502b5d5) to head (ab1d73e).
⚠️ Report is 127 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61285      +/-   ##
==========================================
+ Coverage   87.99%   88.53%   +0.53%     
==========================================
  Files         704      704              
  Lines      208759   208761       +2     
  Branches    40190    40279      +89     
==========================================
+ Hits       183696   184824    +1128     
+ Misses      17003    15942    -1061     
+ Partials     8060     7995      -65
Files with missing lines Coverage Δ
lib/_http_common.js 100.00% <100.00%> (ø)

... and 103 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Renegade334
Renegade334 reviewed Jan 6, 2026
View reviewed changes
@Meltedd Meltedd force-pushed the fix-rawheaders-limit branch from c10e28e to ab1d73e Compare January 6, 2026 20:29
@pimterry pimterry added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 7, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 8, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 8, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70733/

mcollina
mcollina approved these changes Jan 11, 2026
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 20, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70928/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 22, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70969/

@Renegade334 Renegade334 added request-ci Add this label to start a Jenkins CI on a PR. commit-queue Add this label to land a pull request using GitHub Actions. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 22, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 22, 2026
@nodejs-github-bot nodejs-github-bot merged commit 34abee5 into nodejs:main Jan 22, 2026
70 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 22, 2026

Landed in 34abee5

aduh95 pushed a commit that referenced this pull request Jan 24, 2026
@Meltedd @aduh95
http: fix rawHeaders exceeding maxHeadersCount limit
24033ee 
Fixes: #61284
PR-URL: #61285
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
islandryu pushed a commit to islandryu/node that referenced this pull request Jan 25, 2026
@Meltedd @islandryu
http: fix rawHeaders exceeding maxHeadersCount limit
460810b 
Fixes: nodejs#61284
PR-URL: nodejs#61285
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@pimterry pimterry pimterry approved these changes

@Renegade334 Renegade334 Renegade334 approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

+1 more reviewer

@metcoder95 metcoder95 metcoder95 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rawHeaders can exceed maxHeadersCount limit due to batch flush logic

7 participants

@Meltedd @nodejs-github-bot @mcollina @pimterry @Renegade334 @metcoder95 @Ethan-Arrowood